Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 511073002: Restore outline on focus for security warnings (Closed)

Created:
6 years, 3 months ago by felt
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Restore outline on focus for security warnings When tab focus is placed on the security warning primary button, Chrome should outline the button. However, the outline is not shown during button activation to prevent it from making the button border an odd white-gray-blue. BUG=387163 R=bauerb@chromium.org Committed: https://crrev.com/3814de2af30c50450e1db7ee03b126169b975d86 Cr-Commit-Position: refs/heads/master@{#292384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/browser/resources/security_warnings/interstitial_v2.css View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
felt
Hi Bernhard, PTAL.
6 years, 3 months ago (2014-08-28 02:12:15 UTC) #1
Bernhard Bauer
LGTM Screenshots would be nice.
6 years, 3 months ago (2014-08-28 06:17:37 UTC) #2
felt
On 2014/08/28 06:17:37, Bernhard Bauer wrote: > LGTM > > Screenshots would be nice. I ...
6 years, 3 months ago (2014-08-28 14:07:58 UTC) #3
felt
The CQ bit was checked by felt@chromium.org
6 years, 3 months ago (2014-08-28 14:08:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/511073002/1
6 years, 3 months ago (2014-08-28 14:08:27 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-28 15:11:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1ac3e505898fe02116c1de73996a4abef18e2b22
6 years, 3 months ago (2014-08-28 15:21:42 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3814de2af30c50450e1db7ee03b126169b975d86
Cr-Commit-Position: refs/heads/master@{#292384}

Powered by Google App Engine
This is Rietveld 408576698