Shrink the search box if the width is too small.

Shrink the search box if the width is too small.

BUG=408600
R=oshima@chromium.org
TEST=manually

Committed: https://crrev.com/1c5b7a8a7d7884ae6b96d22149d55164dad94a72
Cr-Commit-Position: refs/heads/master@{#292694}

[oshima, 2014-08-28 20:44:52]

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
File athena/home/athena_start_page_view.cc (right):

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view.cc:43: const int kSearchBoxWidth = kIconSize
* 6 + kIconMargin * 7;
can you document this logic?

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
File athena/home/athena_start_page_view_unittest.cc (right):

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view_unittest.cc:41: 
// views::ViewsTestBase:

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view_unittest.cc:67: gfx::Rect icons_bounds() {
The actual code is complicated enough that this should use

GetIconBounds(), rather than icon_bounds().

new line between methods, and cost.

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view_unittest.cc:98: static const size_t kNumApps;
optional: you can just put it in anonymous namespace.

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view_unittest.cc:136: Rotate();
Can you test the re-layout scenario (Wide->narrow->wide)?

Calling this Rotate is a bit confusing. Maybe you can just change it to takes
width and set it from the test?

[Jun Mukai, 2014-08-28 21:55:37]

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
File athena/home/athena_start_page_view.cc (right):

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view.cc:43: const int kSearchBoxWidth = kIconSize
* 6 + kIconMargin * 7;
On 2014/08/28 20:44:51, oshima wrote:
> can you document this logic?

Done.

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
File athena/home/athena_start_page_view_unittest.cc (right):

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view_unittest.cc:41: 
On 2014/08/28 20:44:52, oshima wrote:
> // views::ViewsTestBase:

Done but I personally prefers to have the original declaration, means
testing::Test

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view_unittest.cc:67: gfx::Rect icons_bounds() {
On 2014/08/28 20:44:52, oshima wrote:
> The actual code is complicated enough that this should use
> 
> GetIconBounds(), rather than icon_bounds().
> 
> new line between methods, and cost.

Done.

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view_unittest.cc:98: static const size_t kNumApps;
On 2014/08/28 20:44:52, oshima wrote:
> optional: you can just put it in anonymous namespace.

Done.

https://codereview.chromium.org/511053003/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view_unittest.cc:136: Rotate();
On 2014/08/28 20:44:52, oshima wrote:
> Can you test the re-layout scenario (Wide->narrow->wide)?
> 
> Calling this Rotate is a bit confusing. Maybe you can just change it to takes
> width and set it from the test?

Done.

[Jun Mukai, 2014-08-29 17:15:51]

ping

[oshima, 2014-08-29 17:47:18]

lgtm

https://codereview.chromium.org/511053003/diff/40001/athena/home/athena_start...
File athena/home/athena_start_page_view.cc (right):

https://codereview.chromium.org/511053003/diff/40001/athena/home/athena_start...
athena/home/athena_start_page_view.cc:45: // icons) with margins.
can you update the comment as discussed offline?

[Jun Mukai, 2014-08-29 18:36:30]

https://codereview.chromium.org/511053003/diff/40001/athena/home/athena_start...
File athena/home/athena_start_page_view.cc (right):

https://codereview.chromium.org/511053003/diff/40001/athena/home/athena_start...
athena/home/athena_start_page_view.cc:45: // icons) with margins.
On 2014/08/29 17:47:18, oshima wrote:
> can you update the comment as discussed offline?

Done.

[Jun Mukai, 2014-08-29 18:36:34]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-08-29 18:38:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/511053003/60001

[commit-bot: I haz the power, 2014-08-29 22:37:06]

Committed patchset #4 (id:60001) as 91f72d70606a337acf5993a75faaeaacd17536df

[commit-bot: I haz the power, 2014-09-10 03:10:54]

Patchset 4 (id:??) landed as
https://crrev.com/1c5b7a8a7d7884ae6b96d22149d55164dad94a72
Cr-Commit-Position: refs/heads/master@{#292694}