Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/auto_bisect/bisect.cfg

Issue 511043002: Rename run-bisect-perf-regression.cfg -> auto_bisect/bisect.cfg (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix PRESUBMIT.py so that it checks for the config file in its new location. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/auto_bisect/README ('k') | tools/run-bisect-perf-regression.cfg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/auto_bisect/bisect.cfg
diff --git a/tools/run-bisect-perf-regression.cfg b/tools/auto_bisect/bisect.cfg
similarity index 57%
rename from tools/run-bisect-perf-regression.cfg
rename to tools/auto_bisect/bisect.cfg
index 085a0fc58b70f0ec62680b8c2dc2a000d8000a38..91fdd70319f0e1e649e95f3dbda1cefb9a4f239e 100644
--- a/tools/run-bisect-perf-regression.cfg
+++ b/tools/auto_bisect/bisect.cfg
@@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-"""Config file for Run Performance Test Bisect Tool
+"""Config file read by run-bisect-perf-regression.py.
This script is intended for use by anyone that wants to run a remote bisection
on a range of revisions to look for a performance regression. Modify the config
@@ -12,67 +12,50 @@ run a git try <bot>.
Changes to this file should never be submitted.
Args:
- 'command': This is the full command line to pass to the
- bisect-perf-regression.py script in order to execute the test.
+ 'command': This is the full command to execute the test.
'good_revision': An svn or git revision where the metric hadn't regressed yet.
- 'bad_revision': An svn or git revision sometime after the metric had
- regressed.
+ 'bad_revision': An svn or git revision sometime after the metric regressed.
'metric': The name of the metric to parse out from the results of the
performance test. You can retrieve the metric by looking at the stdio of
the performance test. Look for lines of the format:
-
- RESULT <graph>: <trace>= <value> <units>
-
+ RESULT <graph>: <trace>= <value> <units>
The metric name is "<graph>/<trace>".
'repeat_count': The number of times to repeat the performance test.
'max_time_minutes': The script will attempt to run the performance test
"repeat_count" times, unless it exceeds "max_time_minutes".
- 'truncate_percent': Discard the highest/lowest % values from performance test.
+ 'truncate_percent': The highest/lowest % values will be discarded before
+ computing the mean result for each revision.
Sample config:
config = {
- 'command': './tools/perf/run_measurement --browser=release blink_perf third_party/WebKit/PerformanceTests/Layout/floats_50_100.html',
- 'good_revision': '233015',
- 'bad_revision': '233115',
- 'metric': 'floats_50_100/floats_50_100',
- 'repeat_count': '20',
- 'max_time_minutes': '20',
- 'truncate_percent': '25',
-}
-
-On Windows:
- - If you're calling a python script you will need to add "python" to
-the command:
-
-config = {
- 'command': 'python tools/perf/run_measurement -v --browser=release kraken',
- 'good_revision': '185319',
- 'bad_revision': '185364',
+ 'command': './tools/perf/run_benchmark --browser=release sunspider',
'metric': 'Total/Total',
+ 'good_revision': '14ac2486c0eba1266d2da1c52e8759d9c784fe80',
+ 'bad_revision': 'fcf8643d31301eea990a4c42d7d8c9fc30cc33ec',
'repeat_count': '20',
'max_time_minutes': '20',
'truncate_percent': '25',
}
+For Windows, if you're calling a python script you will need to add "python"
+to the command, so the command would be changed to:
+ 'python tools/perf/run_benchmark -v --browser=release sunspider',
-On ChromeOS:
- - Script accepts either ChromeOS versions, or unix timestamps as revisions.
+For ChromeOS:
+ - For good and bad revision, the script may accept either ChromeOS versions
+ or unix timestamps.
- You don't need to specify --identity and --remote, they will be added to
- the command using the bot's BISECT_CROS_IP and BISECT_CROS_BOARD values.
+ the command using the bot's BISECT_CROS_IP and BISECT_CROS_BOARD values
+ - Example:
config = {
- 'command': './tools/perf/run_measurement -v '\
- '--browser=cros-chrome-guest '\
- 'dromaeo tools/perf/page_sets/dromaeo/jslibstylejquery.json',
+ 'command': ('./tools/perf/run_measurement -v --browser=cros-chrome-guest '
+ 'dromaeo.jslibstylejquery')
'good_revision': '4086.0.0',
'bad_revision': '4087.0.0',
'metric': 'jslib/jslib',
- 'repeat_count': '20',
- 'max_time_minutes': '20',
- 'truncate_percent': '25',
}
-
"""
config = {
« no previous file with comments | « tools/auto_bisect/README ('k') | tools/run-bisect-perf-regression.cfg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698