Add storyboard support.

Add storyboard support.

Add ibtool support for storyboards.  Storyboards also seem to flex an issue
in ibtool where relative paths cause weirdness.  Xcode passes absolute paths
to ibtool, so changing to abs paths here as well.

BUG=314728
R=pkl@chromium.org, thakis@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1778

[pkl (ping after 24h if needed), 2013-10-30 16:47:14]

https://codereview.chromium.org/51103013/diff/1/pylib/gyp/xcode_emulation.py
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/51103013/diff/1/pylib/gyp/xcode_emulation.py#...
pylib/gyp/xcode_emulation.py:1071: output = output[0:-10] + 'storyboardc'
os.path.basename(output) + '.storyboardc'

[justincohen, 2013-10-30 16:53:58]

https://codereview.chromium.org/51103013/diff/1/pylib/gyp/xcode_emulation.py
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/51103013/diff/1/pylib/gyp/xcode_emulation.py#...
pylib/gyp/xcode_emulation.py:1071: output = output[0:-10] + 'storyboardc'
Won't that append .storyboardc to .storyboard?  I though it's supposed to
replace the extension, no?
On 2013/10/30 16:47:14, pklpkl wrote:
> os.path.basename(output) + '.storyboardc'

[pkl (ping after 24h if needed), 2013-10-30 16:57:22]

https://codereview.chromium.org/51103013/diff/1/pylib/gyp/xcode_emulation.py
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/51103013/diff/1/pylib/gyp/xcode_emulation.py#...
pylib/gyp/xcode_emulation.py:1071: output = output[0:-10] + 'storyboardc'
On 2013/10/30 16:53:59, justincohen wrote:
> Won't that append .storyboardc to .storyboard?  I though it's supposed to
> replace the extension, no?
> On 2013/10/30 16:47:14, pklpkl wrote:
> > os.path.basename(output) + '.storyboardc'
> 

Isn't there some built-in os.path function that strips the extension so you
don't have a constant "-10" there?

[pkl (ping after 24h if needed), 2013-10-30 17:18:10]

lgtm

[justincohen, 2013-11-01 14:10:35]

Adding storyboard support regularly (but not always) hit the weird path problem.
 I tried creating an ibpool but that didn't seem to work.  Changing to abs path
-- which is what Xcode seems to do, seemed to work.

PTAL!

[Nico, 2013-11-01 14:22:55]

Did you dtrace? I'd like to understand why abs paths are needed.

On 2013/11/01 14:10:35, justincohen wrote:
> Adding storyboard support regularly (but not always) hit the weird path
problem.
>  I tried creating an ibpool but that didn't seem to work.  Changing to abs
path
> -- which is what Xcode seems to do, seemed to work.
> 
> PTAL!

[justincohen, 2013-11-01 15:07:41]

I didn't.  Any tips on what dtrace command to run?

[justincohen, 2013-11-04 19:12:56]

Nico, do I need to update this bug to point to any of the ibtool information? 
If this doesn't need to wait on that, any other changes?

[Nico, 2013-11-04 19:16:25]

On 2013/11/04 19:12:56, justincohen wrote:
> Nico, do I need to update this bug to point to any of the ibtool information?

Yes.
 
> If this doesn't need to wait on that, any other changes?

[Nico, 2013-11-04 19:20:24]

https://codereview.chromium.org/51103013/diff/280001/pylib/gyp/mac_tool.py
File pylib/gyp/mac_tool.py (right):

https://codereview.chromium.org/51103013/diff/280001/pylib/gyp/mac_tool.py#ne...
pylib/gyp/mac_tool.py:66: # ibtool sometimes fails with relative paths.
Once you filed the crbug. please add a link to it here.

https://codereview.chromium.org/51103013/diff/280001/pylib/gyp/xcode_emulatio...
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/51103013/diff/280001/pylib/gyp/xcode_emulatio...
pylib/gyp/xcode_emulation.py:1071: output = output[0:-10] + 'storyboardc'
s/10/len('storyboard')/

(maybe s/-3/len('xib')/ two lines above for consistency, but counting characters
in 'xib' is easier than in 'storyboard' so not as important)

https://codereview.chromium.org/51103013/diff/280001/test/ios/gyptest-app-ios.py
File test/ios/gyptest-app-ios.py (right):

https://codereview.chromium.org/51103013/diff/280001/test/ios/gyptest-app-ios...
test/ios/gyptest-app-ios.py:38: chdir='app-bundle')
Does xcode do any transformation on the output? If so, should these be checked
for?

[justincohen, 2013-11-05 18:08:08]

PTAL!

https://codereview.chromium.org/51103013/diff/280001/pylib/gyp/mac_tool.py
File pylib/gyp/mac_tool.py (right):

https://codereview.chromium.org/51103013/diff/280001/pylib/gyp/mac_tool.py#ne...
pylib/gyp/mac_tool.py:66: # ibtool sometimes fails with relative paths.
On 2013/11/04 19:20:25, Nico wrote:
> Once you filed the crbug. please add a link to it here.

Done.

https://codereview.chromium.org/51103013/diff/280001/pylib/gyp/xcode_emulatio...
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/51103013/diff/280001/pylib/gyp/xcode_emulatio...
pylib/gyp/xcode_emulation.py:1071: output = output[0:-10] + 'storyboardc'
On 2013/11/04 19:20:25, Nico wrote:
> s/10/len('storyboard')/
> 
> (maybe s/-3/len('xib')/ two lines above for consistency, but counting
characters
> in 'xib' is easier than in 'storyboard' so not as important)

How about using splittext?

https://codereview.chromium.org/51103013/diff/280001/test/ios/gyptest-app-ios.py
File test/ios/gyptest-app-ios.py (right):

https://codereview.chromium.org/51103013/diff/280001/test/ios/gyptest-app-ios...
test/ios/gyptest-app-ios.py:38: chdir='app-bundle')
I think Xcode just calls ibtool as well, so it's the same as ninja.

On 2013/11/04 19:20:25, Nico wrote:
> Does xcode do any transformation on the output? If so, should these be checked
> for?

[Nico, 2013-11-05 18:11:17]

splitext works too. lgtm, thanks!

https://codereview.chromium.org/51103013/diff/450001/pylib/gyp/mac_tool.py
File pylib/gyp/mac_tool.py (right):

https://codereview.chromium.org/51103013/diff/450001/pylib/gyp/mac_tool.py#ne...
pylib/gyp/mac_tool.py:66: # ibtool sometimes crashes with relative paths. Filed
as radar://15392442
Can you openrdar this please? (and then paste the openrdar bug into the crbug
and just say "See crbug.com/314728" here)

[justincohen, 2013-11-05 18:21:22]

https://codereview.chromium.org/51103013/diff/450001/pylib/gyp/mac_tool.py
File pylib/gyp/mac_tool.py (right):

https://codereview.chromium.org/51103013/diff/450001/pylib/gyp/mac_tool.py#ne...
pylib/gyp/mac_tool.py:66: # ibtool sometimes crashes with relative paths. Filed
as radar://15392442
On 2013/11/05 18:11:18, Nico wrote:
> Can you openrdar this please? (and then paste the openrdar bug into the crbug
> and just say "See crbug.com/314728" here)

Done.

[justincohen, 2013-11-05 18:29:01]

Committed patchset #7 manually as r1778 (presubmit successful).