Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 511023002: Revert of Re-enable memory tests. Fixed sign-in issue. (Closed)

Created:
6 years, 3 months ago by tonyg
Modified:
6 years, 3 months ago
Reviewers:
Victor Starodub, Sami
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable memory tests. Fixed sign-in issue. (patchset #3 of https://codereview.chromium.org/491863003/) Reason for revert: Failing on bots. Looks like we forgot to commit the archive. Traceback (most recent call last): File "/b/build/slave/Android_Nexus5_Perf/build/src/tools/perf/../telemetry/telemetry/value/failure.py", line 39, in _GetExcInfoFromMessage raise Exception(message) Exception: Page set archive doesn't exist. http://chromegw/i/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1480/steps/memory.mobile_memory/logs/stdio Original issue's description: > Re-enable memory tests. Fixed sign-in issue. > > Re-recording other tests may be required. > > BUG=370977 > > Committed: https://chromium.googlesource.com/chromium/src/+/383ffaab6b5fac34b950d9faaab637cc75907aca TBR=skyostil@chromium.org,starodub@google.com NOTREECHECKS=true NOTRY=true BUG=370977 Committed: https://crrev.com/a8ae96e7508f8fd8303dc4e2d5eb45615725763a Cr-Commit-Position: refs/heads/master@{#292266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M tools/perf/benchmarks/memory.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/data/mobile_memory.json View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/google_credentials_backend.py View 1 chunk +1 line, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/google_credentials_backend_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tonyg
Created Revert of Re-enable memory tests. Fixed sign-in issue.
6 years, 3 months ago (2014-08-27 23:10:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/511023002/1
6 years, 3 months ago (2014-08-27 23:12:06 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 23:13:19 UTC) #3
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 23:13:20 UTC) #4
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 3 months ago (2014-08-27 23:30:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/511023002/1
6 years, 3 months ago (2014-08-27 23:32:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as caa5deeefeba56916ebc1669730d6176fb37b561
6 years, 3 months ago (2014-08-27 23:35:14 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:55:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8ae96e7508f8fd8303dc4e2d5eb45615725763a
Cr-Commit-Position: refs/heads/master@{#292266}

Powered by Google App Engine
This is Rietveld 408576698