Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 511003002: Don't let PRR kick in if there is less than a packets worth of bytes in (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
Reviewers:
rjshade, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't let PRR kick in if there is less than a packets worth of bytes in flight. Merge internal change: 74165077 Renabled flaky LargePostZeroRTTFailure to see if this CL fixes issue 407756 on chromeos valgrind. R=rch@chromium.org, rjshade@chromium.org BUG=407756 Committed: https://crrev.com/287ca0fe18fdf242706025626cd1652f2daab6dc Cr-Commit-Position: refs/heads/master@{#292369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ramant (doing other things)
6 years, 3 months ago (2014-08-27 22:18:13 UTC) #1
Ryan Hamilton
lgtm
6 years, 3 months ago (2014-08-27 22:25:54 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 3 months ago (2014-08-28 05:13:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/511003002/1
6 years, 3 months ago (2014-08-28 05:14:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_arm64_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 05:56:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 06:22:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/1018)
6 years, 3 months ago (2014-08-28 06:22:20 UTC) #7
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 3 months ago (2014-08-28 12:15:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/511003002/1
6 years, 3 months ago (2014-08-28 12:15:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 65d2d3c916779c36283ae0debe9be7c046089d77
6 years, 3 months ago (2014-08-28 12:37:00 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/287ca0fe18fdf242706025626cd1652f2daab6dc
Cr-Commit-Position: refs/heads/master@{#292369}

Powered by Google App Engine
This is Rietveld 408576698