Register granting of previously withheld permissions as a permissions

chrome/browser/extensions/crx_installer_browsertest.cc

Index: chrome/browser/extensions/crx_installer_browsertest.cc
diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc
index 3bef3d6ada0a9620c23d489d7a38f6b01a43becc..a5ff309c1c5268c0e10ef418e74e68c8ef3c90de 100644
--- a/chrome/browser/extensions/crx_installer_browsertest.cc
+++ b/chrome/browser/extensions/crx_installer_browsertest.cc
@@ -564,4 +564,27 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, ManagementPolicy) {
   EXPECT_FALSE(InstallExtension(crx_path, 0));
 }
 
+IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, WithheldElevationCheck) {
+  // Enable consent flag and install extension. All host permissions will be

[Devlin, 2014/09/09 16:04:26]

This is actually wrong.  It's not that "All host permissions will be withheld",
but rather that "the <all_hosts> permission will be withheld".  There's a pretty
sizable difference there.

[gpdavis, 2014/09/09 17:48:53]

Ah, understood.  Will change.

+  // withheld.
+  scoped_ptr<FeatureSwitch::ScopedOverride> enable_scripts_switch(
+      new FeatureSwitch::ScopedOverride(
+          FeatureSwitch::scripts_require_action(), true));
+
+  base::FilePath crx_path = test_data_dir_.AppendASCII("withheld.crx");

[Devlin, 2014/09/09 16:04:26]

If we can, let's avoid introducing more crxs into the test data dir.  They're
not human-readable, so it makes the tests a bit harder to read (even if you
comment).  Instead, let's go ahead and use a combination of TestExtensionDir and
ExtensionBrowserTest::PackExtension().

[gpdavis, 2014/09/09 17:48:53]

Sure thing.

+  const extensions::Extension* extension = InstallExtension(crx_path, 1);
+  EXPECT_TRUE(base::PathExists(extension->path()));
+
+  std::string id = extension->id();
+  ExtensionService* service = extensions::ExtensionSystem::Get(
+      browser()->profile())->extension_service();
+  EXPECT_TRUE(service->GetExtensionById(id, false));

[Devlin, 2014/09/09 16:04:26]

This really and truly and honestly is fully deprecated.  I made sure when you
told me last time there wasn't a comment. :)

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

[gpdavis, 2014/09/09 17:48:53]

Ah, sorry about that.  I borrowed code from another test in the file, and didn't
notice that it used that deprecated method.  I'm gonna go ahead and switch the
rest of them in the file over.

+
+  // Disable consent flag and reinstall extension. It should now be disabled
+  // because previously withheld permissions are now being requested.
+  enable_scripts_switch.reset();
+  extension = InstallExtension(crx_path, -1);
+  EXPECT_FALSE(service->IsExtensionEnabled(id));
+}
+
 }  // namespace extensions