tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py - Issue 510943002: [Telemetry] Implement CanLaunchApplication and InstallApplication for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

Issue 510943002: [Telemetry] Implement CanLaunchApplication and InstallApplication for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@platform

Patch Set: Fix unittest Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/android_platform_backend.py ('k') | tools/telemetry/telemetry/unittest/system_stub.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

index 634dfb29305af29b40190e2d8f22cf85949d5218..64cf6e3b75f9b297a6554fe386c99796aff2c957 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

@@ -36,7 +36,9 @@ class OOMKillerProfiler(profiler.Profiler):

os.path.join('apks', 'MemConsumer.apk'), 'android')

assert mem_consumer_path, ('Could not find memconsumer app. Please build '

'memconsumer target.')

- self._browser_backend.adb.Install(mem_consumer_path)

+ if not self._platform_backend.CanLaunchApplication(

+ 'org.chromium.memconsumerg'):

+ self._platform_backend.InstallApplication(mem_consumer_path)

self._browser_backend.adb.device().GoHome()

self._platform_backend.LaunchApplication(

'org.chromium.memconsumer/.MemConsumer',