tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py - Issue 510943002: [Telemetry] Implement CanLaunchApplication and InstallApplication for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py

Issue 510943002: [Telemetry] Implement CanLaunchApplication and InstallApplication for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@platform

Patch Set: Fix unittest Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py ('k') | tools/telemetry/telemetry/core/browser_options.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py

index de9e72a83d9a0b10147346aefadeeaf1800af0c4..f4ce39c08dcf12ebbaa3c84c7ed10ce68c7c7465 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py

@@ -33,7 +33,7 @@ class AndroidBrowserFinderTest(unittest.TestCase):

def test_no_adb(self):

finder_options = browser_options.BrowserFinderOptions()

- def NoAdb(*args, **kargs): # pylint: disable=W0613

+ def NoAdb(*args, **kargs): # pylint: disable=W0613

raise OSError('not found')

self._stubs.subprocess.Popen = NoAdb

browsers = android_browser_finder.FindAllAvailableBrowsers(

@@ -86,7 +86,11 @@ class AndroidBrowserFinderTest(unittest.TestCase):

return ['package:org.chromium.content_shell_apk',

'package.com.google.android.setupwizard']

+ def OnLs(_):

+ return ['/sys/devices/system/cpu/cpu0']

self._stubs.adb_commands.shell_command_handlers['pm'] = OnPM

+ self._stubs.adb_commands.shell_command_handlers['ls'] = OnLs

browsers = android_browser_finder.FindAllAvailableBrowsers(

finder_options, self._log_stub)