Issue 510923002: Fixed void* to uint64_t cast on win64 in TraceID.

Issue 510923002: Fixed void* to uint64_t cast on win64 in TraceID. (Closed)

Created:
6 years, 3 months ago by cjacek

Modified:
4 years, 11 months ago

Reviewers:
bungeman-skia, humper

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Fixed void* to uint64_t cast on win64 in TraceID. On win64, long is 32-bit. Found by GCC (mingw-w64) build, where this causes an error. This is the Skia version of https://codereview.chromium.org/374043002 . Committed: https://skia.googlesource.com/skia/+/3e15f9006cc0a6a9f1f153e87d08149b73531d01 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=510923002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/core/SkTraceEvent.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 9 (4 generated)

bungeman-skia

lgtm, but humper should take a look at https://codereview.chromium.org/374043002 and make sure that we don't ...

6 years, 3 months ago (2014-09-10 21:20:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cjacek@gmail.com/510923002/1

6 years, 3 months ago (2014-09-10 21:20:38 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 21:28:10 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 3e15f9006cc0a6a9f1f153e87d08149b73531d01