media/audio/audio_input_controller.cc - Issue 510913005: Add native log and uma stat when all input shared memory buffers are full

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_input_controller.cc

Issue 510913005: Add native log and uma stat when all input shared memory buffers are full (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added unittest and addressed comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/audio_input_controller.cc

diff --git a/media/audio/audio_input_controller.cc b/media/audio/audio_input_controller.cc

index 72fb83b49ae26a4f4f57761bbda7ef449e96c801..17fa259b7372da296664c440eb719ba538cebfc5 100644

--- a/media/audio/audio_input_controller.cc

+++ b/media/audio/audio_input_controller.cc

@@ -474,8 +474,7 @@ void AudioInputController::OnData(AudioInputStream* stream,

// Use SharedMemory and SyncSocket if the client has created a SyncWriter.

// Used by all low-latency clients except WebSpeech.

if (SharedMemoryAndSyncSocketMode()) {

- sync_writer_->Write(source, volume, key_pressed);

- sync_writer_->UpdateRecordedBytes(hardware_delay_bytes);

+ sync_writer_->Write(source, volume, key_pressed, hardware_delay_bytes);

#if defined(AUDIO_POWER_MONITORING)

// Only do power-level measurements if an AudioPowerMonitor object has

« no previous file with comments | « media/audio/audio_input_controller.h ('k') | media/audio/audio_input_device.h » ('j') | media/audio/audio_input_device_unittest.cc » ('J')