Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: media/audio/audio_input_controller.h

Issue 510913005: Add native log and uma stat when all input shared memory buffers are full (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_input_controller.h
diff --git a/media/audio/audio_input_controller.h b/media/audio/audio_input_controller.h
index 5d555766a18cecbc87fbf4e6603642e4b8a7cd78..0886bb46035aea9183eaeb392fbfcf188dd38181 100644
--- a/media/audio/audio_input_controller.h
+++ b/media/audio/audio_input_controller.h
@@ -132,14 +132,12 @@ class MEDIA_EXPORT AudioInputController
public:
virtual ~SyncWriter() {}
- // Notify the synchronous writer about the number of bytes in the
- // soundcard which has been recorded.
- virtual void UpdateRecordedBytes(uint32 bytes) = 0;
-
- // Write certain amount of data from |data|.
+ // Write certain amount of data from |data| and notify the synchronous
+ // writer on the number of bytes in the sound card which has been recorded.
tommi (sloooow) - chröme 2014/08/29 09:16:43 grammar nit: // writer of the number of bytes that
no longer working on chromium 2014/08/29 11:14:16 The previous comments are just wrong, I tried corr
virtual void Write(const AudioBus* data,
double volume,
- bool key_pressed) = 0;
+ bool key_pressed,
+ uint32 bytes) = 0;
// Close this synchronous writer.
virtual void Close() = 0;

Powered by Google App Engine
This is Rietveld 408576698