Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: gyp/images.gyp

Issue 510913003: Disable bitmap decoders for GPU specific formats on Android framework (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/images.gyp
diff --git a/gyp/images.gyp b/gyp/images.gyp
index 3cc66a0adb9dc05a39affef25bead39811c43723..13cf3bbf9a8c1aff95940c72d98d34558b32fc40 100644
--- a/gyp/images.gyp
+++ b/gyp/images.gyp
@@ -14,13 +14,6 @@
'libwebp.gyp:libwebp',
'utils.gyp:utils',
],
- 'conditions': [
- [ 'skia_android_framework == 0', {
- 'export_dependent_settings': [
- 'libjpeg.gyp:*',
- ],
- }],
- ],
'include_dirs': [
'../include/images',
'../src/lazy',
@@ -141,7 +134,16 @@
'conditions': [
[ 'skia_android_framework == 0', {
'export_dependent_settings': [
- 'android_deps.gyp:png'
+ 'android_deps.gyp:png',
+ 'libjpeg.gyp:*'
+ ],
+ }, {
+ # The android framework disables these decoders as they are of little use to
+ # Java applications that can't take advantage of the compressed formats.
+ 'sources!': [
robertphillips 2014/08/27 20:15:48 I thought Android did support ETC1 compressed imag
+ '../src/images/SkImageDecoder_pkm.cpp',
+ '../src/images/SkImageDecoder_ktx.cpp',
+ '../src/images/SkImageDecoder_astc.cpp',
],
}],
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698