Issue 510913003: Disable bitmap decoders for GPU specific formats on Android framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 510913003: Disable bitmap decoders for GPU specific formats on Android framework (Closed)

Created:
6 years, 3 months ago by djsollen

Modified:
6 years, 3 months ago

Reviewers:
scroggo, robertphillips, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Disable bitmap decoders for GPU specific formats on Android framework Committed: https://skia.googlesource.com/skia/+/38e44b06b246cfb06c11a18d552913ccee4a4440

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
	M	gyp/images.gyp	View		2 chunks	+10 lines, -8 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

djsollen

djsollen@google.com changed reviewers: + reed@google.com, robertphillips@google.com, scroggo@google.com

6 years, 3 months ago (2014-08-27 19:57:23 UTC) #1

robertphillips

lgtm https://codereview.chromium.org/510913003/diff/1/gyp/images.gyp File gyp/images.gyp (right): https://codereview.chromium.org/510913003/diff/1/gyp/images.gyp#newcode143 gyp/images.gyp:143: 'sources!': [ I thought Android did support ETC1 ...

6 years, 3 months ago (2014-08-27 20:15:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/510913003/1

6 years, 3 months ago (2014-08-27 20:21:22 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-08-28 12:41:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 38e44b06b246cfb06c11a18d552913ccee4a4440

Expand Messages | Collapse Messages