dbus/util.cc - Issue 510863002: dbus::ObjectManager: Add a match rule for properties before GetManagedObjects.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: dbus/util.cc

Issue 510863002: dbus::ObjectManager: Add a match rule for properties before GetManagedObjects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Round 2 comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "dbus/util.h"

	6

	7 namespace dbus {

	8

	9 std::string GetAbsoluteMemberName(const std::string& interface_name,

	10 const std::string& member_name) {

	11 return interface_name + "." + member_name;
	satorux1 2014/09/04 04:25:33 It may sound a bit silly to have a unit test for t It may sound a bit silly to have a unit test for this function, but I'd be happy if you could create a util_unittest.cc and add a test for this. Having util_unittest.cc makes it easier for us to add new tests when new functions are added to this file. armansito 2014/09/05 00:47:11 I'd rather not get this CL any larger, since I int Show quoted text On 2014/09/04 04:25:33, satorux1 wrote: > It may sound a bit silly to have a unit test for this function, but I'd be happy > if you could create a util_unittest.cc and add a test for this. Having > util_unittest.cc makes it easier for us to add new tests when new functions are > added to this file. I'd rather not get this CL any larger, since I intend to merge this to 38 asap. I'll follow this up with another CL that adds a util_unittest on ToT.
	12 }

	13

	14 } // namespace dbus

OLD	NEW

« dbus/util.h ('K') | « dbus/util.h ('k') | no next file » | no next file with comments »