dbus::ObjectManager: Add a match rule for properties before GetManagedObjects.

dbus/bus.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "dbus/bus.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
@@ skipping 249 matching lines @@
                                        const base::Closure& callback) {
   AssertOnOriginThread();
 
   // Check if we have the requested object proxy.
   const ObjectProxyTable::key_type key(service_name + object_path.value(),
                                        options);
   ObjectProxyTable::iterator iter = object_proxy_table_.find(key);
   if (iter != object_proxy_table_.end()) {
     scoped_refptr<ObjectProxy> object_proxy = iter->second;
     object_proxy_table_.erase(iter);
-    // Object is present. Remove it now and Detach in the DBus thread.
+    // Object is present. Remove it now and Detach on the DBus thread.
     GetDBusTaskRunner()->PostTask(
         FROM_HERE,
         base::Bind(&Bus::RemoveObjectProxyInternal,
                    this, object_proxy, callback));
     return true;
   }
   return false;
 }
 
 void Bus::RemoveObjectProxyInternal(scoped_refptr<ObjectProxy> object_proxy,
@@ skipping 63 matching lines @@
   }
 
   scoped_refptr<ObjectManager> object_manager =
       new ObjectManager(this, service_name, object_path);
   object_manager_table_[key] = object_manager;
 
   return object_manager.get();
 }
 
 void Bus::RemoveObjectManager(const std::string& service_name,
-                              const ObjectPath& object_path) {
+                              const ObjectPath& object_path,
+                              const base::Closure& callback) {
   AssertOnOriginThread();

[satorux1, 2014/08/28 04:00:01]

add: DCHECK(!callback.is_null()); to make it clear that the callback must not be
null

[armansito, 2014/08/28 15:37:59]

Done.

 
   const ObjectManagerTable::key_type key(service_name + object_path.value());
   ObjectManagerTable::iterator iter = object_manager_table_.find(key);
   if (iter == object_manager_table_.end())
     return;
 
+  // ObjectManager is present. Remove it now and CleanUp in the DBus thread.

[satorux1, 2014/08/28 04:00:01]

in -> on ?

[armansito, 2014/08/28 15:37:59]

Done.

   scoped_refptr<ObjectManager> object_manager = iter->second;
   object_manager_table_.erase(iter);
+
+  GetDBusTaskRunner()->PostTask(
+      FROM_HERE,
+      base::Bind(&Bus::RemoveObjectManagerInternal,
+                 this, object_manager, callback));
+}
+
+void Bus::RemoveObjectManagerInternal(
+      scoped_refptr<dbus::ObjectManager> object_manager,
+      const base::Closure& callback) {
+  AssertOnDBusThread();
+  DCHECK(object_manager.get());
+
+  object_manager->CleanUp();
+
+  GetOriginTaskRunner()->PostTask(FROM_HERE, callback);
 }
 
 void Bus::GetManagedObjects() {
   for (ObjectManagerTable::iterator iter = object_manager_table_.begin();
        iter != object_manager_table_.end(); ++iter) {
     iter->second->GetManagedObjects();
   }
 }
 
 bool Bus::Connect() {
@@ skipping 79 matching lines @@
     LOG(ERROR) << "Failed to release all service names. # of services left: "
                << owned_service_names_.size();
   }
 
   // Detach from the remote objects.
   for (ObjectProxyTable::iterator iter = object_proxy_table_.begin();
        iter != object_proxy_table_.end(); ++iter) {
     iter->second->Detach();
   }
 
+  // Clean up the object managers.
+  for (ObjectManagerTable::iterator iter = object_manager_table_.begin();
+       iter != object_manager_table_.end(); ++iter) {
+    iter->second->CleanUp();
+  }
+
   // Release object proxies and exported objects here. We should do this
   // here rather than in the destructor to avoid memory leaks due to
   // cyclic references.
   object_proxy_table_.clear();
   exported_object_table_.clear();
 
   // Private connection should be closed.
   if (connection_) {
     // Remove Disconnected watcher.
     ScopedDBusError error;
@@ skipping 716 matching lines @@
                              kNameOwnerChangedSignal)) {
     Bus* self = static_cast<Bus*>(data);
     self->OnServiceOwnerChanged(message);
   }
   // Always return unhandled to let others, e.g. ObjectProxies, handle the same
   // signal.
   return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;
 }
 
 }  // namespace dbus