Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 510813002: Organize ServiceWorkerCacheStorage's methods. (Closed)

Created:
6 years, 3 months ago by jkarlin
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@guarantee2
Project:
chromium
Visibility:
Public.

Description

Organize ServiceWorkerCacheStorage's methods. Part of the following CL chain to guarantee callbacks are called throughout ServiceWorkerCacheStorage: 1. Guarantee CacheLoader callbacks: https://codereview.chromium.org/504233003/ 2. Guarantee LazyInit callbacks: https://codereview.chromium.org/512743002/ 3. Guarantee Create/Delete callbacks: https://codereview.chromium.org/511893002/ * 4. Reorganize the methods: https://codereview.chromium.org/510813002/ BUG=392621

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -50 lines) Patch
M content/browser/service_worker/service_worker_cache_storage.h View 3 chunks +12 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage.cc View 4 chunks +40 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jkarlin
jkarlin@chromium.org changed reviewers: + michaeln@chromium.org
6 years, 3 months ago (2014-08-27 14:47:57 UTC) #1
jkarlin
michaeln: Please review all. Thanks!
6 years, 3 months ago (2014-08-27 14:47:57 UTC) #2
jkarlin
jkarlin@chromium.org changed reviewers: + horo@chromium.org
6 years, 3 months ago (2014-08-27 16:12:27 UTC) #3
jkarlin
On 2014/08/27 16:12:27, jkarlin wrote: > mailto:jkarlin@chromium.org changed reviewers: > + mailto:horo@chromium.org horo + michaeln: ...
6 years, 3 months ago (2014-08-27 16:15:28 UTC) #4
jkarlin
jkarlin@chromium.org changed reviewers: - horo@chromium.org, michaeln@chromium.org
6 years, 3 months ago (2014-08-28 11:03:37 UTC) #5
jkarlin
6 years, 3 months ago (2014-08-28 11:05:28 UTC) #6 
On 2014/08/28 11:03:37, jkarlin wrote:
> mailto:jkarlin@chromium.org changed reviewers:
> - mailto:horo@chromium.org, mailto:michaeln@chromium.org

Removed reviewers as this patch isn't required and adds complexity.

Powered by Google App Engine
This is Rietveld 408576698