Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: ui/events/gestures/gesture_provider_aura_unittest.cc

Issue 510793003: Remove ui::TouchEvent -> blink::WebTouchEvent conversion methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix broken test. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/gestures/gesture_provider_aura.cc ('k') | ui/events/gestures/motion_event_aura.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/gestures/gesture_provider_aura_unittest.cc
diff --git a/ui/events/gestures/gesture_provider_aura_unittest.cc b/ui/events/gestures/gesture_provider_aura_unittest.cc
index 9b52dd3e549038c368fcdea03ad72ea490a6ee22..79e06a8dc95fb9d9238550310622b54e11a79eb0 100644
--- a/ui/events/gestures/gesture_provider_aura_unittest.cc
+++ b/ui/events/gestures/gesture_provider_aura_unittest.cc
@@ -37,8 +37,11 @@ TEST_F(GestureProviderAuraTest, IgnoresExtraPressEvents) {
time += base::TimeDelta::FromMilliseconds(10);
TouchEvent press2(ET_TOUCH_PRESSED, gfx::PointF(30, 40), 0, time);
- // Redundant press with same id is ignored.
- EXPECT_FALSE(provider()->OnTouchEvent(&press2));
+ // TODO(tdresser): this redundant press with same id should be
+ // ignored; however, there is at least one case where we need to
+ // allow a touch press from a currently used touch id. See
+ // crbug.com/373125 for details.
+ EXPECT_TRUE(provider()->OnTouchEvent(&press2));
}
TEST_F(GestureProviderAuraTest, IgnoresExtraMoveOrReleaseEvents) {
« no previous file with comments | « ui/events/gestures/gesture_provider_aura.cc ('k') | ui/events/gestures/motion_event_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698