Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: ui/aura/gestures/gesture_recognizer_unittest.cc

Issue 510793003: Remove ui::TouchEvent -> blink::WebTouchEvent conversion methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address jdduke's comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/gestures/gesture_recognizer_unittest.cc
diff --git a/ui/aura/gestures/gesture_recognizer_unittest.cc b/ui/aura/gestures/gesture_recognizer_unittest.cc
index 1efe90c680ab2a02c9c6296cc11da84aec9f3e8b..fed5ea462eef8f1241a98d20c385247c90c0e631 100644
--- a/ui/aura/gestures/gesture_recognizer_unittest.cc
+++ b/ui/aura/gestures/gesture_recognizer_unittest.cc
@@ -2550,10 +2550,12 @@ TEST_F(GestureRecognizerTest, PressDoesNotCrash) {
ui::TouchEvent press2(ui::ET_TOUCH_PRESSED, gfx::Point(55, 45), 7, tes.Now());
DispatchEventUsingWindowDispatcher(&press2);
- // This new press should not generate a tap-down.
- EXPECT_FALSE(delegate->begin());
+ // FIXME(tdresser): this should not generate a tap down; however,
+ // there is at least one case where we need to allow a touch press
+ // from a currently used touch id. See crbug.com/373125 for details.
+ EXPECT_TRUE(delegate->begin());
EXPECT_FALSE(delegate->tap_down());
- EXPECT_FALSE(delegate->tap_cancel());
+ EXPECT_TRUE(delegate->tap_cancel());
EXPECT_FALSE(delegate->scroll_begin());
}

Powered by Google App Engine
This is Rietveld 408576698