content/browser/renderer_host/input/web_input_event_util.cc - Issue 510793003: Remove ui::TouchEvent -> blink::WebTouchEvent conversion methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_util.cc

Issue 510793003: Remove ui::TouchEvent -> blink::WebTouchEvent conversion methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make method const. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/input/web_input_event_util.cc

diff --git a/content/browser/renderer_host/input/web_input_event_util.cc b/content/browser/renderer_host/input/web_input_event_util.cc

index bfba064bdf6889c5778526f601429c194affc65e..3f265e1f44d8a5bb0d8af57c6a941c5bad2971f4 100644

--- a/content/browser/renderer_host/input/web_input_event_util.cc

+++ b/content/browser/renderer_host/input/web_input_event_util.cc

@@ -274,7 +274,6 @@ blink::WebTouchEvent CreateWebTouchEventFromMotionEvent(

result.touchesLength =

std::min(event.GetPointerCount(),

static_cast<size_t>(WebTouchEvent::touchesLengthCap));

- DCHECK_GT(result.touchesLength, 0U);

jdduke (slow) 2015/01/06 16:49:54 I'm a little nervous about removing this DCHECK.

tdresser 2015/01/07 17:01:15 I've re-added it, at the expense of making the Ren

for (size_t i = 0; i < result.touchesLength; ++i)

result.touches[i] = CreateWebTouchPoint(event, i);

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_aura.h » ('j') | ui/events/gestures/gesture_provider_aura.cc » ('J')