Issue 510773002: Add Flags<T> class as a type-safe way of storing OR-combinations of enums.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 510773002: Add Flags<T> class as a type-safe way of storing OR-combinations of enums. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add Flags<T> class as a type-safe way of storing OR-combinations of enums. TEST=base-unittests R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23453

Patch Set 2 : Make GCC happy. #

Patch Set 5 : Drop copy & assign #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -0 lines)			Patch
M	BUILD.gn	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/base/flags.h	View	1 2 3 4	1 chunk	+120 lines, -0 lines	0 comments	Download
M	test/base-unittests/base-unittests.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	test/base-unittests/flags-unittest.cc	View	1 2 3	1 chunk	+103 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

bmeurer@chromium.org changed reviewers: + svenpanne@chromium.org

6 years, 3 months ago (2014-08-27 11:57:38 UTC) #1

Sven Panne

LGTM with a nit https://codereview.chromium.org/510773002/diff/60001/src/base/flags.h File src/base/flags.h (right): https://codereview.chromium.org/510773002/diff/60001/src/base/flags.h#newcode30 src/base/flags.h:30: Flags(const Flags& flags) : mask_(flags.mask_) ...

6 years, 3 months ago (2014-08-27 12:15:02 UTC) #3

Benedikt Meurer

6 years, 3 months ago (2014-08-27 12:16:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as 23453 (tree was closed).

Expand Messages | Collapse Messages

Issue 510773002: Add Flags<T> class as a type-safe way of storing OR-combinations of enums. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Make GCC happy. #

Patch Set 3 : Style fixes. #

Patch Set 4 : BUILD.gn #

Patch Set 5 : Drop copy & assign #

Messages