Issue 51073002: Move HashTools.h to core/css

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 51073002: Move HashTools.h to core/css (Closed)

Created:
7 years, 1 month ago by rwlbuis

Modified:
7 years, 1 month ago

Reviewers:
eseidel, Inactive, abarth-chromium

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -43 lines)			Patch
M	Source/build/scripts/make_css_property_names.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/build/scripts/make_css_value_keywords.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/core.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSParser-in.cpp	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	Source/core/css/HashTools.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	Source/core/platform/HashTools.h	View	1 chunk	+0 lines, -40 lines	0 comments	Download

Total messages: 4 (0 generated)

rwlbuis

We should probably move HashTools.h to core rather than platform/ since only core/css uses it.

7 years, 1 month ago (2013-10-29 17:44:02 UTC) #1

eseidel

lgtm Rather horrible name for that file. It's the front-end to the gperf file afaict.

7 years, 1 month ago (2013-10-29 17:58:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/51073002/1

7 years, 1 month ago (2013-10-29 18:16:30 UTC) #3

Message was sent while issue was closed.

Change committed as 160863