Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 510713002: Expand minimum size of the window to avoid cut off context menu (Closed)

Created:
6 years, 3 months ago by iseki
Modified:
6 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Expand minimum size of the window to avoid cut off context menu BUG=259656 TEST=manually Committed: https://crrev.com/8fc5ed50a6a5908953285b10f786ef8f580f360d Cr-Commit-Position: refs/heads/master@{#292348}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/background/js/background.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
iseki
iseki@chromium.org changed reviewers: + hirono@chromium.org
6 years, 3 months ago (2014-08-27 07:54:53 UTC) #1
iseki
Please take a look.
6 years, 3 months ago (2014-08-27 07:54:53 UTC) #2
hirono
lgtm. Thanks!
6 years, 3 months ago (2014-08-27 08:42:35 UTC) #3
iseki
The CQ bit was checked by iseki@chromium.org
6 years, 3 months ago (2014-08-28 00:36:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/510713002/1
6 years, 3 months ago (2014-08-28 00:37:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:35:40 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 01:35:41 UTC) #7
iseki
The CQ bit was checked by iseki@chromium.org
6 years, 3 months ago (2014-08-28 01:47:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/510713002/1
6 years, 3 months ago (2014-08-28 01:48:08 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:49:17 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 01:49:18 UTC) #11
iseki
The CQ bit was checked by iseki@chromium.org
6 years, 3 months ago (2014-08-28 07:24:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/510713002/20001
6 years, 3 months ago (2014-08-28 07:26:03 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0d255c504acc32f63b1807015132a12e65045c25
6 years, 3 months ago (2014-08-28 08:20:32 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:58:28 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8fc5ed50a6a5908953285b10f786ef8f580f360d
Cr-Commit-Position: refs/heads/master@{#292348}

Powered by Google App Engine
This is Rietveld 408576698