Issue 510703002: DevTools: remove methods used for native memory instrumentation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 510703002: DevTools: remove methods used for native memory instrumentation (Closed)

Created:
6 years, 3 months ago by yurys

Modified:
6 years, 3 months ago

Reviewers:
vsevik, loislo

CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: remove methods used for native memory instrumentation The instrumentation was dropped and the code is unused. BUG=None Committed: https://crrev.com/a2c9ec97f6e95bdfe65877b371784b437bc37391 Cr-Commit-Position: refs/heads/master@{#292117}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	content/renderer/devtools/devtools_agent.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	content/renderer/devtools/devtools_agent.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

yurys

yurys@chromium.org changed reviewers: + loislo@chromium.org, vsevik@chromium.org

6 years, 3 months ago (2014-08-27 06:33:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/510703002/1

6 years, 3 months ago (2014-08-27 06:36:24 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (1) as ab56e8711292da694c94aaa184dddcc1aef22952

6 years, 3 months ago (2014-08-27 07:52:34 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:50:27 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a2c9ec97f6e95bdfe65877b371784b437bc37391
Cr-Commit-Position: refs/heads/master@{#292117}

Expand Messages | Collapse Messages