Issue 510693003: Sync our homegrown SysInfo replacement with the one in Chrome base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 510693003: Sync our homegrown SysInfo replacement with the one in Chrome base. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Sync our homegrown SysInfo replacement with the one in Chrome base. Also fix several inconsistencies/bugs on the way. TEST=base-unittests R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23435

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -116 lines)			Patch
M	BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/base/platform/platform.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/base/platform/platform-posix.cc	View		1 chunk	+0 lines, -71 lines	0 comments	Download
M	src/base/platform/platform-win32.cc	View		3 chunks	+0 lines, -24 lines	0 comments	Download
A	src/base/sys-info.h	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	src/base/sys-info.cc	View	1	1 chunk	+122 lines, -0 lines	0 comments	Download
M	src/d8.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/isolate.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/libplatform/default-platform.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	test/base-unittests/base-unittests.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/base-unittests/platform/platform-unittest.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
A	test/base-unittests/sys-info-unittest.cc	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

bmeurer@chromium.org changed reviewers: + svenpanne@chromium.org

6 years, 3 months ago (2014-08-27 07:59:20 UTC) #1

Benedikt Meurer

6 years, 3 months ago (2014-08-27 08:29:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 23435 (presubmit successful).