Issue 510673002: Add more logging to get information from plugin tests when they flake.

Issue 510673002: Add more logging to get information from plugin tests when they flake. (Closed)

Created:
6 years, 3 months ago by jam

Modified:
6 years, 3 months ago

Reviewers:
scottmg

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add more logging to get information from plugin tests when they flake. TBR=scottmg@chromium.org Committed: https://crrev.com/6b5a37cda57d01f0077f7970ef1d14a823075399 Cr-Commit-Position: refs/heads/master@{#292108}

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	content/child/npapi/webplugin_delegate_impl_win.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/510673002/1

6 years, 3 months ago (2014-08-27 04:45:23 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (1) as 8a65ae9babd7de5d1fbd774d31d9e9cf5e845320

6 years, 3 months ago (2014-08-27 06:50:24 UTC) #4

scottmg

lgtm https://codereview.chromium.org/510673002/diff/1/content/child/npapi/webplugin_delegate_impl_win.cc File content/child/npapi/webplugin_delegate_impl_win.cc (right): https://codereview.chromium.org/510673002/diff/1/content/child/npapi/webplugin_delegate_impl_win.cc#newcode511 content/child/npapi/webplugin_delegate_impl_win.cc:511: DCHECK_NE(0, plugin_name_atom) << " last error = " ...

6 years, 3 months ago (2014-08-27 16:58:57 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:50:10 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6b5a37cda57d01f0077f7970ef1d14a823075399
Cr-Commit-Position: refs/heads/master@{#292108}

Expand Messages | Collapse Messages