Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 510653004: Add Android copy_directory_contents_[to|from]_device scripts (Closed)

Created:
6 years, 3 months ago by borenet
Modified:
6 years, 3 months ago
Reviewers:
djsollen, derek1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add Android copy_directory_contents_[to|from]_device scripts BUG=skia: NOTRY=true R=djsollen@google.com Committed: https://skia.googlesource.com/skia/+/60d3054

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
A platform_tools/android/bin/adb_pull_if_needed View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A platform_tools/android/bin/adb_push_if_needed View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
borenet
borenet@google.com changed reviewers: + djsollen@google.com
6 years, 3 months ago (2014-08-28 11:56:14 UTC) #1
borenet
6 years, 3 months ago (2014-08-28 11:56:14 UTC) #2
derek1
derek@derekandbritt.com changed reviewers: + derek@derekandbritt.com
6 years, 3 months ago (2014-08-28 12:49:22 UTC) #3
derek1
I'm fine with the direction of the CL, but don't care for the program names ...
6 years, 3 months ago (2014-08-28 12:49:22 UTC) #4
borenet
On 2014/08/28 12:49:22, derek1 wrote: > I'm fine with the direction of the CL, but ...
6 years, 3 months ago (2014-08-28 13:10:06 UTC) #5
djsollen
lgtm, but can you test that this doesn't screw up our existing scripts now that ...
6 years, 3 months ago (2014-08-28 13:16:52 UTC) #6
borenet
On 2014/08/28 13:16:52, djsollen wrote: > lgtm, but can you test that this doesn't screw ...
6 years, 3 months ago (2014-08-28 13:23:05 UTC) #7
djsollen
well then LGTM.
6 years, 3 months ago (2014-08-28 13:26:43 UTC) #8
borenet
The CQ bit was checked by borenet@google.com
6 years, 3 months ago (2014-08-28 13:30:02 UTC) #9
borenet
The CQ bit was unchecked by borenet@google.com
6 years, 3 months ago (2014-08-28 13:30:36 UTC) #10
borenet
6 years, 3 months ago (2014-08-28 13:31:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 manually as 60d3054 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698