Improve the ScopedHandle verifier.

Improve the ScopedHandle verifier.

1. Automate the selection of the proper channel to enable the verifier.
   Now the code is enabled at runtime.

2. Switch to a hash_map to track handles.

3. Intercept CloseHandle to detect the code that is closing handles owned
   by ScopedHandles. The initial implementation only covers chrome.exe/dll,
   but the plan is to extend that in the future to all modules loaded in the
   process.

BUG=362176
See https://codereview.chromium.org/490043002/ for the initial review.

Committed: https://crrev.com/86d7c90f6a309ecf7b499e8c2c30490d6e1f03ba
Cr-Commit-Position: refs/heads/master@{#293365}

[rvargas (doing something else), 2014-09-02 22:10:49]

rvargas@chromium.org changed reviewers:
+ cpu@chromium.org

[rvargas (doing something else), 2014-09-02 22:10:50]

PTAL. Patch set 1 was commited/reverted.

[cpu_(ooo_6.6-7.5), 2014-09-03 22:10:14]

lgtm

https://codereview.chromium.org/510633002/diff/60001/base/win/scoped_handle.cc
File base/win/scoped_handle.cc (right):

https://codereview.chromium.org/510633002/diff/60001/base/win/scoped_handle.c...
base/win/scoped_handle.cc:122: g_verifier_enabled = false;
a note above 121 as of why g_verifier_enabled is not protected by the lock will
be welcome.

[rvargas (doing something else), 2014-09-04 01:00:13]

rvargas@chromium.org changed reviewers:
+ sky@chromium.org

[rvargas (doing something else), 2014-09-04 01:00:14]

Thanks.

sky, do you mind taking a look again at the build files? Patch set 1 is the code
as last reviewed.

[sky, 2014-09-04 02:49:59]

https://codereview.chromium.org/510633002/diff/80001/chrome/chrome_dll.gypi
File chrome/chrome_dll.gypi (right):

https://codereview.chromium.org/510633002/diff/80001/chrome/chrome_dll.gypi#n...
chrome/chrome_dll.gypi:307: '../components/components.gyp:crash_component',
What are you doing this change?

[rvargas (doing something else), 2014-09-04 03:12:27]

Thanks

https://codereview.chromium.org/510633002/diff/80001/chrome/chrome_dll.gypi
File chrome/chrome_dll.gypi (right):

https://codereview.chromium.org/510633002/diff/80001/chrome/chrome_dll.gypi#n...
chrome/chrome_dll.gypi:307: '../components/components.gyp:crash_component',
On 2014/09/04 02:49:58, sky wrote:
> What are you doing this change?

yeah, diff vs PS1 doesn't work that well here because it gets changes not made
by me. Sorry :(  (that is to say, nothing really changed in this file from ps1)

[sky, 2014-09-04 13:23:46]

Ah, you had a merge in there. ok, LGTM

[rvargas (doing something else), 2014-09-04 17:47:11]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2014-09-04 17:50:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rvargas@chromium.org/510633002/80001

[commit-bot: I haz the power, 2014-09-04 22:59:24]

Committed patchset #5 (id:80001) as 16a1887895873970cd427eb76e4e76d9695ad031

[commit-bot: I haz the power, 2014-09-10 03:33:37]

Patchset 5 (id:??) landed as
https://crrev.com/86d7c90f6a309ecf7b499e8c2c30490d6e1f03ba
Cr-Commit-Position: refs/heads/master@{#293365}