Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 510623002: Fix a couple small problems with tools/unused-grit-header.py. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
tfarina, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a couple small problems with tools/unused-grit-header.py. - Checking the wrong nodes due to a typo in the previous code review. - Handle the case of GRD files that do not emit a header file. NOTRY=true Committed: https://crrev.com/e1608a4fc7ece209109ca3a69c32b23a880ed41f Cr-Commit-Position: refs/heads/master@{#292062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tools/unused-grit-header.py View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
thestig@chromium.org changed reviewers: + thakis@chromium.org
6 years, 3 months ago (2014-08-27 00:52:18 UTC) #1
Lei Zhang
Bleh
6 years, 3 months ago (2014-08-27 00:52:18 UTC) #2
Nico
lgtm with s/omit/emit/ in the description (i think)
6 years, 3 months ago (2014-08-27 00:53:15 UTC) #3
Lei Zhang
On 2014/08/27 00:53:15, Nico (hiding) wrote: > lgtm with s/omit/emit/ in the description (i think) ...
6 years, 3 months ago (2014-08-27 01:00:46 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-27 01:00:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/510623002/1
6 years, 3 months ago (2014-08-27 01:01:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 9761e6921ca31e85321448edc066de4c87cefbea
6 years, 3 months ago (2014-08-27 01:12:14 UTC) #7
tfarina
tfarina@chromium.org changed reviewers: + tfarina@chromium.org
6 years, 3 months ago (2014-08-27 19:21:23 UTC) #8
tfarina
lgtm (rubber-stamp).
6 years, 3 months ago (2014-08-27 19:21:23 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1608a4fc7ece209109ca3a69c32b23a880ed41f
Cr-Commit-Position: refs/heads/master@{#292062}

Powered by Google App Engine
This is Rietveld 408576698