Improve a poor implementation of "find duplicates".

Improve a poor implementation of "find duplicates".

BUG=407718
Committed: https://crrev.com/33da11d3d057abf0481a4ce4efd5408837f33e77
Cr-Commit-Position: refs/heads/master@{#292385}

[eroman, 2014-08-26 23:44:30]

eroman@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2014-08-27 17:15:59]

https://codereview.chromium.org/510583002/diff/1/content/child/webcrypto/test...
File content/child/webcrypto/test/test_helpers.cc (right):

https://codereview.chromium.org/510583002/diff/1/content/child/webcrypto/test...
content/child/webcrypto/test/test_helpers.cc:249: }
This seems to be memory intensive.

Why not just sort and then do a linear scan?

[eroman, 2014-08-27 18:47:06]

https://codereview.chromium.org/510583002/diff/1/content/child/webcrypto/test...
File content/child/webcrypto/test/test_helpers.cc (right):

https://codereview.chromium.org/510583002/diff/1/content/child/webcrypto/test...
content/child/webcrypto/test/test_helpers.cc:249: }
On 2014/08/27 17:15:58, Ryan Sleevi wrote:
> This seems to be memory intensive.
> 
> Why not just sort and then do a linear scan?

Done. I also modified it to sort a vector of indices to avoid moving lots of
data.

[Ryan Sleevi, 2014-08-27 18:51:02]

lgtm

[eroman, 2014-08-27 18:53:13]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-08-27 18:54:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/510583002/40001

[commit-bot: I haz the power, 2014-08-27 20:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 20:13:53]

Failed to commit the patch.

[eroman, 2014-08-27 20:29:10]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-08-27 20:30:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/510583002/40001

[commit-bot: I haz the power, 2014-08-27 20:31:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 20:31:09]

Failed to commit the patch.

[eroman, 2014-08-27 22:19:29]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-08-27 22:20:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/510583002/60001

[commit-bot: I haz the power, 2014-08-27 23:21:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 23:21:24]

Failed to commit the patch.

[eroman, 2014-08-28 14:40:59]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-08-28 14:41:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/510583002/80001

[commit-bot: I haz the power, 2014-08-28 15:38:01]

Committed patchset #5 (id:80001) as 5468922cf3c975b236a60b56bc30f9467f41fd3b

[commit-bot: I haz the power, 2014-09-10 02:59:39]

Patchset 5 (id:??) landed as
https://crrev.com/33da11d3d057abf0481a4ce4efd5408837f33e77
Cr-Commit-Position: refs/heads/master@{#292385}