Temporary allocation of 20Mb before and after call to ServiceProcessControl::GetHistograms.

Temporary allocation of 20Mb before and after call to ServiceProcessControl::GetHistograms.

BUG=406227
Committed: https://crrev.com/f89ce26c97949d224441ed45644a7d41b89bcf69
Cr-Commit-Position: refs/heads/master@{#292325}

[Vitaly Buka (NO REVIEWS), 2014-08-28 00:28:31]

vitalybuka@chromium.org changed reviewers:
+ tapted@chromium.org

[Vitaly Buka (NO REVIEWS), 2014-08-28 00:28:31]

I don't have better idea for now.

[tapted, 2014-08-28 01:07:28]

nice idea -seems to me like good science :). lgtm

https://codereview.chromium.org/510563004/diff/20001/chrome/browser/service_p...
File chrome/browser/service_process/service_process_control.cc (right):

https://codereview.chromium.org/510563004/diff/20001/chrome/browser/service_p...
chrome/browser/service_process/service_process_control.cc:33: void* buffer =
malloc(20 * 1024 * 1024);
nit: Maybe guard these lines in #if defined(OS_MACOSX) - pretty sure the crashes
are only happening there. I'd also say something on the function comment like

// Test: On Mac, launchd_msg_send tries to allocate a 10MB buffer, but doesn't
// handle errors and makes ugly crash dumps when close to OOM.

[Vitaly Buka (NO REVIEWS), 2014-08-28 03:24:51]

https://codereview.chromium.org/510563004/diff/20001/chrome/browser/service_p...
File chrome/browser/service_process/service_process_control.cc (right):

https://codereview.chromium.org/510563004/diff/20001/chrome/browser/service_p...
chrome/browser/service_process/service_process_control.cc:33: void* buffer =
malloc(20 * 1024 * 1024);
On 2014/08/28 01:07:27, tapted wrote:
> nit: Maybe guard these lines in #if defined(OS_MACOSX) - pretty sure the
crashes
> are only happening there. I'd also say something on the function comment like
> 
> // Test: On Mac, launchd_msg_send tries to allocate a 10MB buffer, but doesn't
> // handle errors and makes ugly crash dumps when close to OOM.

Done.

[Vitaly Buka (NO REVIEWS), 2014-08-28 03:24:54]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-08-28 03:26:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/510563004/60001

[commit-bot: I haz the power, 2014-08-28 04:18:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-08-28 05:30:12]

Committed patchset #4 (id:60001) as 896843eb980c0912e695d897e5f0ebb447990902

[commit-bot: I haz the power, 2014-09-10 02:57:42]

Patchset 4 (id:??) landed as
https://crrev.com/f89ce26c97949d224441ed45644a7d41b89bcf69
Cr-Commit-Position: refs/heads/master@{#292325}

[Vitaly Buka (NO REVIEWS), 2014-09-22 23:41:10]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/595673003/ by vitalybuka@chromium.org.

The reason for reverting is: We have gathered enough evidence..