Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 510543002: Introduce ItemPosition class for enhanced bookmarks. (Closed)

Created:
6 years, 3 months ago by Rune Fevang
Modified:
6 years, 3 months ago
CC:
Yaron, Mark
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Introduce ItemPosition class for enhanced bookmarks. This class will be used for setting/reading the string positions used by the enhanced bookmarks. BUG=411412 Committed: https://crrev.com/a3db1c4f5c38b56b7aa7bd7bf8ff48e54e24587a Cr-Commit-Position: refs/heads/master@{#293674}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : Comments and comparison functions #

Total comments: 11

Patch Set 5 : Yaron comments #

Patch Set 6 : Rename to ItemPosition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -0 lines) Patch
M components/components_tests.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/enhanced_bookmarks.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A components/enhanced_bookmarks/item_position.h View 1 2 3 4 5 1 chunk +57 lines, -0 lines 0 comments Download
A components/enhanced_bookmarks/item_position.cc View 1 2 3 4 5 1 chunk +178 lines, -0 lines 0 comments Download
A components/enhanced_bookmarks/item_position_unittest.cc View 1 2 3 4 5 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (7 generated)
Rune Fevang
rfevang@chromium.org changed reviewers: + noyau@chromium.org
6 years, 3 months ago (2014-08-26 22:23:19 UTC) #1
Rune Fevang
Ping
6 years, 3 months ago (2014-09-04 18:54:07 UTC) #3
Mark
https://codereview.chromium.org/510543002/diff/40001/components/enhanced_bookmarks/stars_position.cc File components/enhanced_bookmarks/stars_position.cc (right): https://codereview.chromium.org/510543002/diff/40001/components/enhanced_bookmarks/stars_position.cc#newcode12 components/enhanced_bookmarks/stars_position.cc:12: ".0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvwxyz"; So the key question here is consistency. What ...
6 years, 3 months ago (2014-09-04 21:51:24 UTC) #5
Rune Fevang
https://codereview.chromium.org/510543002/diff/40001/components/enhanced_bookmarks/stars_position.cc File components/enhanced_bookmarks/stars_position.cc (right): https://codereview.chromium.org/510543002/diff/40001/components/enhanced_bookmarks/stars_position.cc#newcode12 components/enhanced_bookmarks/stars_position.cc:12: ".0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvwxyz"; On 2014/09/04 21:51:24, Mark wrote: > So the ...
6 years, 3 months ago (2014-09-04 22:56:47 UTC) #6
Mark
Looks good to me, but we still need OWNERS approval. https://codereview.chromium.org/510543002/diff/40001/components/enhanced_bookmarks/stars_position.cc File components/enhanced_bookmarks/stars_position.cc (right): https://codereview.chromium.org/510543002/diff/40001/components/enhanced_bookmarks/stars_position.cc#newcode12 ...
6 years, 3 months ago (2014-09-05 01:02:00 UTC) #7
Yaron
https://codereview.chromium.org/510543002/diff/60001/components/enhanced_bookmarks/stars_position.cc File components/enhanced_bookmarks/stars_position.cc (right): https://codereview.chromium.org/510543002/diff/60001/components/enhanced_bookmarks/stars_position.cc#newcode33 components/enhanced_bookmarks/stars_position.cc:33: bool StarsPosition::IsValid() const { nit: ordering should match header ...
6 years, 3 months ago (2014-09-05 03:52:03 UTC) #8
Yaron
https://codereview.chromium.org/510543002/diff/60001/components/enhanced_bookmarks/stars_position.cc File components/enhanced_bookmarks/stars_position.cc (right): https://codereview.chromium.org/510543002/diff/60001/components/enhanced_bookmarks/stars_position.cc#newcode67 components/enhanced_bookmarks/stars_position.cc:67: // This will cause the returned string will be ...
6 years, 3 months ago (2014-09-05 03:52:23 UTC) #9
Yaron
also, please add a tracking bug
6 years, 3 months ago (2014-09-05 04:09:44 UTC) #10
Rune Fevang
https://codereview.chromium.org/510543002/diff/60001/components/enhanced_bookmarks/stars_position.cc File components/enhanced_bookmarks/stars_position.cc (right): https://codereview.chromium.org/510543002/diff/60001/components/enhanced_bookmarks/stars_position.cc#newcode33 components/enhanced_bookmarks/stars_position.cc:33: bool StarsPosition::IsValid() const { On 2014/09/05 03:52:02, Yaron wrote: ...
6 years, 3 months ago (2014-09-05 19:02:31 UTC) #11
Yaron
https://codereview.chromium.org/510543002/diff/60001/components/enhanced_bookmarks/stars_position.h File components/enhanced_bookmarks/stars_position.h (right): https://codereview.chromium.org/510543002/diff/60001/components/enhanced_bookmarks/stars_position.h#newcode15 components/enhanced_bookmarks/stars_position.h:15: class StarsPosition { On 2014/09/05 19:02:30, Rune Fevang wrote: ...
6 years, 3 months ago (2014-09-05 19:52:13 UTC) #12
Rune Fevang
https://codereview.chromium.org/510543002/diff/60001/components/enhanced_bookmarks/stars_position.h File components/enhanced_bookmarks/stars_position.h (right): https://codereview.chromium.org/510543002/diff/60001/components/enhanced_bookmarks/stars_position.h#newcode15 components/enhanced_bookmarks/stars_position.h:15: class StarsPosition { On 2014/09/05 19:52:13, Yaron wrote: > ...
6 years, 3 months ago (2014-09-05 20:47:08 UTC) #13
Yaron
lgtm
6 years, 3 months ago (2014-09-05 21:15:39 UTC) #14
Rune Fevang
On 2014/09/05 21:15:39, Yaron wrote: > lgtm Thanks! Could you submit this for me Yaron? ...
6 years, 3 months ago (2014-09-05 21:58:33 UTC) #15
Rune Fevang
On 2014/09/05 21:58:33, Rune Fevang wrote: > On 2014/09/05 21:15:39, Yaron wrote: > > lgtm ...
6 years, 3 months ago (2014-09-05 22:02:45 UTC) #16
Rune Fevang
On 2014/09/05 22:02:45, Rune Fevang wrote: > On 2014/09/05 21:58:33, Rune Fevang wrote: > > ...
6 years, 3 months ago (2014-09-05 22:28:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/510543002/100001
6 years, 3 months ago (2014-09-05 23:40:28 UTC) #19
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 05:43:15 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/510543002/100001
6 years, 3 months ago (2014-09-06 06:50:31 UTC) #23
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 12:09:24 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/510543002/100001
6 years, 3 months ago (2014-09-08 02:03:37 UTC) #27
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 6e17967ca948d11bdeb9890dad788f4fbf888784
6 years, 3 months ago (2014-09-08 02:07:06 UTC) #28
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:44:38 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/a3db1c4f5c38b56b7aa7bd7bf8ff48e54e24587a
Cr-Commit-Position: refs/heads/master@{#293674}

Powered by Google App Engine
This is Rietveld 408576698