components/bookmarks/test/test_bookmark_client.cc - Issue 510533002: Omnibox: Make URLs of Bookmarks Searchable - Try 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/test/test_bookmark_client.cc

Issue 510533002: Omnibox: Make URLs of Bookmarks Searchable - Try 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Peter's minor comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/test/test_bookmark_client.cc

diff --git a/components/bookmarks/test/test_bookmark_client.cc b/components/bookmarks/test/test_bookmark_client.cc

index dcfd0325fcaa05e33e7e162359140af3bf6ce94b..67e5f37c4b2edaaeebf2bccb0f91c3dc731c5117 100644

--- a/components/bookmarks/test/test_bookmark_client.cc

+++ b/components/bookmarks/test/test_bookmark_client.cc

@@ -17,8 +17,8 @@ TestBookmarkClient::TestBookmarkClient() {}

TestBookmarkClient::~TestBookmarkClient() {}

-scoped_ptr<BookmarkModel> TestBookmarkClient::CreateModel(bool index_urls) {

- scoped_ptr<BookmarkModel> bookmark_model(new BookmarkModel(this, index_urls));

+scoped_ptr<BookmarkModel> TestBookmarkClient::CreateModel() {

+ scoped_ptr<BookmarkModel> bookmark_model(new BookmarkModel(this));

scoped_ptr<bookmarks::BookmarkLoadDetails> details =

bookmark_model->CreateLoadDetails(std::string());

details->LoadExtraNodes();