chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc - Issue 510533002: Omnibox: Make URLs of Bookmarks Searchable - Try 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

Issue 510533002: Omnibox: Make URLs of Bookmarks Searchable - Try 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Peter's minor comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

index 5d026613dded072c0fa4e01f2b53802744768703..be0ca0c4261a7e5b15854f11898d46a9c2f6888c 100644

--- a/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc

@@ -18,7 +18,7 @@ namespace {

TEST(BookmarkUIUtilsTest, HasBookmarkURLs) {

test::TestBookmarkClient client;

- scoped_ptr<BookmarkModel> model(client.CreateModel(false));

+ scoped_ptr<BookmarkModel> model(client.CreateModel());

std::vector<const BookmarkNode*> nodes;

@@ -60,7 +60,7 @@ TEST(BookmarkUIUtilsTest, HasBookmarkURLs) {

TEST(BookmarkUIUtilsTest, HasBookmarkURLsAllowedInIncognitoMode) {

test::TestBookmarkClient client;

- scoped_ptr<BookmarkModel> model(client.CreateModel(false));

+ scoped_ptr<BookmarkModel> model(client.CreateModel());

TestingProfile profile;

std::vector<const BookmarkNode*> nodes;