Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 510513003: Send Android accessibility event when object location changes (Closed)

Created:
6 years, 3 months ago by dmazzoni
Modified:
6 years, 3 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@update_accessibility_focus_3
Project:
chromium
Visibility:
Public.

Description

Send Android accessibility event when object location changes. Note that the LOCATION_CHANGED event isn't explicitly handled, it just gets mapped to a WINDOW_CONTENT_CHANGED event on Android. BUG=407871 Committed: https://crrev.com/487bac0415731a3f0ca031f2ee181a1c2a3c0043 Cr-Commit-Position: refs/heads/master@{#292216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
dmazzoni
dmazzoni@chromium.org changed reviewers: + plundblad@chromium.org
6 years, 3 months ago (2014-08-26 23:08:29 UTC) #1
dmazzoni
6 years, 3 months ago (2014-08-26 23:08:34 UTC) #2
Peter Lundblad
lgtm Is the location change fired for a root of a subtree or for each ...
6 years, 3 months ago (2014-08-27 09:44:15 UTC) #3
Peter Lundblad
lgtm
6 years, 3 months ago (2014-08-27 09:54:57 UTC) #4
dmazzoni
On 2014/08/27 09:44:15, Peter Lundblad wrote: > Is the location change fired for a root ...
6 years, 3 months ago (2014-08-27 19:28:14 UTC) #5
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 3 months ago (2014-08-27 19:28:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/510513003/1
6 years, 3 months ago (2014-08-27 19:29:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7593bdb9001d5f311bd040c7b9ce3ba8dcdc1168
6 years, 3 months ago (2014-08-27 20:55:07 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/487bac0415731a3f0ca031f2ee181a1c2a3c0043
Cr-Commit-Position: refs/heads/master@{#292216}

Powered by Google App Engine
This is Rietveld 408576698