Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 510513002: [CSS Shapes] Import and fix polygon shapes reftests (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[CSS Shapes] Import and fix polygon shapes reftests Import these polygon shapes reftests and fix them. Note that these tests should be imported at some point. This is based on http://trac.webkit.org/changeset/172973 by Zoltan Horvath <zoltan@webkit.org>;. From the WebKit patch commit log: We didn't respect the shape-margin before a positioned polygon, since we checked the shape-margin for only 1 vertex for a polygon edge. This patch fixes the behavior, removes the tests from the skipped list and updates 1 test, which was incorrect. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181504

Patch Set 1 #

Patch Set 2 : Add tests #

Patch Set 3 : Remove webkit prefixes #

Messages

Total messages: 21 (5 generated)
rwlbuis
rob.buis@samsung.com changed reviewers: + zoltan@adobe.com
6 years, 3 months ago (2014-08-26 21:31:04 UTC) #1
rwlbuis
PTAL!
6 years, 3 months ago (2014-08-26 21:31:04 UTC) #2
Zoltan
lgtm
6 years, 3 months ago (2014-08-27 15:58:40 UTC) #3
rwlbuis
rob.buis@samsung.com changed reviewers: + leviw@chromium.org
6 years, 3 months ago (2014-08-27 16:01:12 UTC) #4
rwlbuis
PTAL
6 years, 3 months ago (2014-08-27 16:01:12 UTC) #5
rwlbuis
rob.buis@samsung.com changed reviewers: + eseidel@chromium.org
6 years, 3 months ago (2014-08-27 22:18:46 UTC) #6
rwlbuis
I heard Levi is OOO this week, so adding Eric.
6 years, 3 months ago (2014-08-27 22:18:46 UTC) #7
rwlbuis
On 2014/08/27 22:18:46, rwlbuis wrote: > I heard Levi is OOO this week, so adding ...
6 years, 3 months ago (2014-09-05 21:03:20 UTC) #8
leviw_travelin_and_unemployed
LGTM. Can you also import the details from the description of the WebKit patch?
6 years, 3 months ago (2014-09-05 21:42:44 UTC) #9
rwlbuis
On 2014/09/05 21:42:44, leviw wrote: > LGTM. > > Can you also import the details ...
6 years, 3 months ago (2014-09-05 22:01:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/510513002/40001
6 years, 3 months ago (2014-09-05 22:14:33 UTC) #12
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 04:15:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/510513002/40001
6 years, 3 months ago (2014-09-06 10:22:12 UTC) #16
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 12:23:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/510513002/40001
6 years, 3 months ago (2014-09-06 23:58:48 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-07 08:15:15 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 181504

Powered by Google App Engine
This is Rietveld 408576698