Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 510483004: Chromecast buildfix: MetricsService has moved to metrics namespace. (Closed)

Created:
6 years, 3 months ago by gunsch
Modified:
6 years, 3 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast buildfix: MetricsService has moved to metrics namespace. R=isherman@chromium.org,lcwu@chromium.org BUG=374763 Committed: https://crrev.com/bf984bb644aaff410d0bd995c518ff3f15030a23 Cr-Commit-Position: refs/heads/master@{#292068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chromecast/metrics/cast_metrics_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/metrics/cast_metrics_service_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/metrics/cast_metrics_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/metrics/platform_metrics_providers.h View 1 chunk +4 lines, -1 line 0 comments Download
M chromecast/metrics/platform_metrics_providers_simple.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
gunsch
6 years, 3 months ago (2014-08-26 23:24:46 UTC) #1
gunsch
gunsch@chromium.org changed reviewers: + isherman@chromium.org - asvitkine@chromium.org
6 years, 3 months ago (2014-08-26 23:25:54 UTC) #2
Alexei Svitkine (slow)
asvitkine@chromium.org changed reviewers: + asvitkine@chromium.org
6 years, 3 months ago (2014-08-26 23:48:42 UTC) #3
Alexei Svitkine (slow)
lgtm - it would be good to get bots up that build this config
6 years, 3 months ago (2014-08-26 23:48:42 UTC) #4
gunsch
On 2014/08/26 23:48:42, Alexei Svitkine - OOO wrote: > lgtm - it would be good ...
6 years, 3 months ago (2014-08-26 23:49:53 UTC) #5
lcwu1
lgtm Regarding trybots for chromecast build, we are looking into it and (hopefully) should have ...
6 years, 3 months ago (2014-08-27 00:26:53 UTC) #6
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 3 months ago (2014-08-27 00:29:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/510483004/1
6 years, 3 months ago (2014-08-27 00:30:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (1) as 1ada66f09322d44391eb1f5683e145ac7a51d9f7
6 years, 3 months ago (2014-08-27 01:30:41 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf984bb644aaff410d0bd995c518ff3f15030a23
Cr-Commit-Position: refs/heads/master@{#292068}

Powered by Google App Engine
This is Rietveld 408576698