Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 510483003: Rename RootViewManager to DisplayManager (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename RootViewManager to DisplayManager DisplayManager is a better name for what the object is intended to do. BUG=none TEST=none R=jamesr@chromium.org Committed: https://crrev.com/344b4602f0495b0bd2fe370277ca2ab9ef59820f Cr-Commit-Position: refs/heads/master@{#292077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -393 lines) Patch
M mojo/mojo_services.gypi View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/display_manager.h View 4 chunks +11 lines, -11 lines 0 comments Download
A + mojo/services/view_manager/display_manager.cc View 5 chunks +10 lines, -10 lines 0 comments Download
A + mojo/services/view_manager/display_manager_delegate.h View 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 3 chunks +9 lines, -9 lines 0 comments Download
D mojo/services/view_manager/root_view_manager.h View 1 chunk +0 lines, -85 lines 0 comments Download
D mojo/services/view_manager/root_view_manager.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D mojo/services/view_manager/root_view_manager_delegate.h View 1 chunk +0 lines, -25 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_context.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sky
6 years, 3 months ago (2014-08-26 23:19:49 UTC) #1
jamesr
lgtm
6 years, 3 months ago (2014-08-26 23:20:43 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 3 months ago (2014-08-26 23:20:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/510483003/1
6 years, 3 months ago (2014-08-26 23:21:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 01:19:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 50e4edfb99a1ec643e6251f4e6d14db50a7f275a
6 years, 3 months ago (2014-08-27 02:01:02 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:49:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/344b4602f0495b0bd2fe370277ca2ab9ef59820f
Cr-Commit-Position: refs/heads/master@{#292077}

Powered by Google App Engine
This is Rietveld 408576698