Issue 510453002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/background/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 510453002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/background/ (Closed)

Created:
6 years, 3 months ago by dcheng

Modified:
6 years, 3 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove implicit conversions from scoped_refptr to T* in chrome/browser/background/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/90dac52b7ac5f95f9ba96e1ba6c04c4aee3b9693 Cr-Commit-Position: refs/heads/master@{#292124}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -16 lines)			Patch
	M	chrome/browser/background/background_mode_manager.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/background/background_mode_manager_unittest.cc	View		4 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dcheng

dcheng@chromium.org changed reviewers: + atwilson@chromium.org

6 years, 3 months ago (2014-08-26 18:07:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/510453002/1

6 years, 3 months ago (2014-08-27 08:16:45 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (1) as 6e7aafe54ec38060998efedcee017c98dc71f077

6 years, 3 months ago (2014-08-27 09:07:55 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:50:40 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/90dac52b7ac5f95f9ba96e1ba6c04c4aee3b9693
Cr-Commit-Position: refs/heads/master@{#292124}

Expand Messages | Collapse Messages