Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 510433002: remove (unused) scale parameter from measureText (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
bungeman-skia, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remove (unused) scale parameter from measureText BUG=skia: Committed: https://skia.googlesource.com/skia/+/99ae881a7f55a03c2b16fb5704e6e90ea86d965d

Patch Set 1 #

Patch Set 2 : remove unused field from struct #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -28 lines) Patch
M include/core/SkPaint.h View 2 chunks +2 lines, -5 lines 0 comments Download
M samplecode/SampleMeasure.cpp View 1 2 chunks +5 lines, -13 lines 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +2 lines, -9 lines 0 comments Download
M tests/PaintTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
reed1
reed@google.com changed reviewers: + bungeman@google.com, djsollen@google.com
6 years, 3 months ago (2014-08-26 16:08:09 UTC) #1
reed1
I think there are no callers in chrome or android
6 years, 3 months ago (2014-08-26 16:08:09 UTC) #2
djsollen
lgtm
6 years, 3 months ago (2014-08-26 17:05:50 UTC) #3
bungeman-skia
lgtm, it seems silly to have a scale here, either a full matrix or nothing ...
6 years, 3 months ago (2014-08-26 17:19:47 UTC) #4
reed1
The CQ bit was checked by reed@google.com
6 years, 3 months ago (2014-08-26 17:55:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/510433002/1
6 years, 3 months ago (2014-08-26 17:56:13 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 3 months ago (2014-08-26 18:03:53 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 18:07:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1152)
6 years, 3 months ago (2014-08-26 18:07:23 UTC) #9
reed1
The CQ bit was checked by reed@google.com
6 years, 3 months ago (2014-08-26 18:08:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/510433002/20001
6 years, 3 months ago (2014-08-26 18:08:12 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-08-26 18:30:08 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 99ae881a7f55a03c2b16fb5704e6e90ea86d965d

Powered by Google App Engine
This is Rietveld 408576698