tests/BitmapTest.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/BitmapTest.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/BitmapTest.cpp

diff --git a/tests/BitmapTest.cpp b/tests/BitmapTest.cpp

index 42ed8841b414dfd2a6807747ab9d74a233cbe8aa..4826b831fe783ec827fdb3a1ec2d079c1b1ead10 100644

--- a/tests/BitmapTest.cpp

+++ b/tests/BitmapTest.cpp

@@ -75,7 +75,7 @@ DEF_TEST(Bitmap, reporter) {

bool setConf = bm.setInfo(SkImageInfo::MakeN32Premul(width, height));

REPORTER_ASSERT(reporter, setConf);

if (setConf) {

- REPORTER_ASSERT(reporter, bm.allocPixels(NULL));

+ bm.allocPixels();

}

REPORTER_ASSERT(reporter, SkToBool(width & height) != bm.empty());

}

« no previous file with comments | « tests/BitmapHasherTest.cpp ('k') | tests/CachedDecodingPixelRefTest.cpp » ('j') | no next file with comments »