tests/BitmapHasherTest.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/BitmapHasherTest.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/BitmapHasherTest.cpp

diff --git a/tests/BitmapHasherTest.cpp b/tests/BitmapHasherTest.cpp

index e39439a11f468170cf711d4c32f8d1a1a0f3e945..3b5170692d1aad8eedb955bbdfa9ce61e8ac51c6 100644

--- a/tests/BitmapHasherTest.cpp

+++ b/tests/BitmapHasherTest.cpp

@@ -17,8 +17,7 @@ typedef uint64_t checksum_result;

// Fill in bitmap with test data.

static void CreateTestBitmap(SkBitmap* bitmap, int width, int height,

SkColor color, skiatest::Reporter* reporter) {

- SkImageInfo info = SkImageInfo::MakeN32(width, height, kOpaque_SkAlphaType);

- REPORTER_ASSERT(reporter, bitmap->allocPixels(info));

+ bitmap->allocN32Pixels(width, height, kOpaque_SkAlphaType);

bitmap->eraseColor(color);

}

« no previous file with comments | « tests/BitmapCopyTest.cpp ('k') | tests/BitmapTest.cpp » ('j') | no next file with comments »