tests/DrawBitmapRectTest.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/DrawBitmapRectTest.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: can't use (void) to suppress the "must check return result" Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/DrawBitmapRectTest.cpp

diff --git a/tests/DrawBitmapRectTest.cpp b/tests/DrawBitmapRectTest.cpp

index 6dca98b527207a086178b07199d6cd839e8c6dc8..720155ca0c01a2f4d11443ac7f81a20b8197ed63 100644

--- a/tests/DrawBitmapRectTest.cpp

+++ b/tests/DrawBitmapRectTest.cpp

@@ -190,7 +190,9 @@ static void test_wacky_bitmapshader(skiatest::Reporter* reporter,

c.concat(matrix);

SkBitmap bm;

- bm.allocN32Pixels(width, height);

+ if (bm.tryAllocN32Pixels(width, height)) {

mtklein 2014/09/02 18:50:26 This one's pretty surprising. The test's exploitin

reed1 2014/09/02 19:35:28 The test explicitly passes in 0xFFFF x 0xFFFF for

+ // allow this to fail silently, to test the code downstream

+ }

bm.eraseColor(SK_ColorRED);

matrix.setAll(0.0078740157f,