tests/CachedDecodingPixelRefTest.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/CachedDecodingPixelRefTest.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: can't use (void) to suppress the "must check return result" Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/CachedDecodingPixelRefTest.cpp

diff --git a/tests/CachedDecodingPixelRefTest.cpp b/tests/CachedDecodingPixelRefTest.cpp

index 65623d0e4f9b0e7527e445353046959f3e6a9be9..7c63a0e9255931cb91197bd7440f415b0f0c15a4 100644

--- a/tests/CachedDecodingPixelRefTest.cpp

+++ b/tests/CachedDecodingPixelRefTest.cpp

@@ -348,8 +348,7 @@ DEF_TEST(Image_NewFromGenerator, r) {

REPORTER_ASSERT(r, TestImageGenerator::Height() == image->height());

SkBitmap bitmap;

- SkAssertResult(bitmap.allocN32Pixels(TestImageGenerator::Width(),

- TestImageGenerator::Height()));

+ bitmap.allocN32Pixels(TestImageGenerator::Width(), TestImageGenerator::Height());

SkCanvas canvas(bitmap);

const SkColor kDefaultColor = 0xffabcdef;

canvas.clear(kDefaultColor);