src/core/SkPictureShader.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPictureShader.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: can't use (void) to suppress the "must check return result" Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPictureShader.cpp

diff --git a/src/core/SkPictureShader.cpp b/src/core/SkPictureShader.cpp

index 73ab170f119cd15948c74fa71b0cde1191b57e56..a7b5412b5a5dabc1a6a584429a229caddf531b48 100644

--- a/src/core/SkPictureShader.cpp

+++ b/src/core/SkPictureShader.cpp

@@ -107,7 +107,7 @@ SkShader* SkPictureShader::refBitmapShader(const SkMatrix& matrix, const SkMatri

if (!fCachedBitmapShader || tileScale != fCachedTileScale) {

SkBitmap bm;

- if (!bm.allocN32Pixels(tileSize.width(), tileSize.height())) {

+ if (!bm.tryAllocN32Pixels(tileSize.width(), tileSize.height())) {

return NULL;

}

bm.eraseColor(SK_ColorTRANSPARENT);