Fixing DataReductionProxy.BypassedBytes.LocalBypassRules

components/data_reduction_proxy/browser/data_reduction_proxy_params.h

Index: components/data_reduction_proxy/browser/data_reduction_proxy_params.h
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
index 651784527a2f46a39addb0dd9d4482dedf422f12..14021b4ac22998e4b2fc1504c6160e668aee9b9f 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
@@ -19,6 +19,7 @@ class TimeDelta;
 }
 
 namespace net {
+class ProxyConfig;
 class URLRequest;
 }
 
@@ -130,6 +131,13 @@ class DataReductionProxyParams {
   // list.
   virtual bool IsDataReductionProxyEligible(const net::URLRequest* request);
 
+  // Returns true if this request could be sent through the data request proxy

[bengr, 2014/09/03 17:06:55]

The return description and the function name seem to contradict. Please change
one or the other. I suggest changing the return so that true means the request
would not go to Flywheel because it would be bypassed by local rules.

Actually, I think that's what your code is doing, but he description is wrong.

[megjablon, 2014/09/03 17:20:12]

Ya, I forgot to change the description when I flip flopped the return.

+  // based on applying the |data_reduction_proxy_config| param rules to the
+  // request URL.
+  bool IsBypassedByDataReductionProxyLocalRules(
+      const net::URLRequest& request,
+      const net::ProxyConfig& data_reduction_proxy_config) const;
+
   // Checks if all configured data reduction proxies are in the retry map.
   // Returns true if the request is bypassed by all configured data reduction
   // proxies and returns the bypass delay in delay_seconds (if not NULL). If