Fixing DataReductionProxy.BypassedBytes.LocalBypassRules

chrome/browser/net/chrome_network_delegate.cc

Index: chrome/browser/net/chrome_network_delegate.cc
diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc
index d69e0eb1a4c4397d0fd21c01eb3284d807baaaf7..69b2ec90bdbf139ce785b4e6798cbf9b4012424a 100644
--- a/chrome/browser/net/chrome_network_delegate.cc
+++ b/chrome/browser/net/chrome_network_delegate.cc
@@ -583,9 +583,13 @@ void ChromeNetworkDelegate::OnCompleted(net::URLRequest* request,
       RecordContentLengthHistograms(received_content_length,
                                     original_content_length,
                                     freshness_lifetime);
-      if (data_reduction_proxy_enabled_ && data_reduction_proxy_usage_stats_) {
+      if (data_reduction_proxy_enabled_ &&
+          data_reduction_proxy_usage_stats_ &&
+          !proxy_config_getter_.is_null()) {
         data_reduction_proxy_usage_stats_->RecordBypassedBytesHistograms(
-            *request, *data_reduction_proxy_enabled_);
+            *request,
+            *data_reduction_proxy_enabled_,
+            proxy_config_getter_.Run());

[mmenke, 2014/09/02 14:30:52]

Can't RecordBypassedBytesHistograms just use request->proxy_server()?  Looking
at the config rather than what proxy was actually used seems weird to me.

[megjablon, 2014/09/02 21:00:16]

To know if the proxy was bypassed because of the data reduction proxy bypass
rules, we need to have the data reduction proxy config to have a handle to those
rules. We also want to know if the effective config is the data reduction proxy
config. This tells us if a managed proxy config is being used and overriding the
use of the data reduction proxy config.

       }
       DVLOG(2) << __FUNCTION__
           << " received content length: " << received_content_length