Fixing DataReductionProxy.BypassedBytes.LocalBypassRules

components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h

Index: components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h b/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h
index f147bb3c9a2a984ad38539588e7b5a5fd868c1b2..5f3f9c554ae04cc6abbe5a6b695eeb1629bdf83c 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h
@@ -61,7 +61,8 @@ class DataReductionProxyUsageStats
   // kDataReductionProxyEnabled preference.
   void RecordBypassedBytesHistograms(
       net::URLRequest& request,
-      const BooleanPrefMember& data_reduction_proxy_enabled);
+      const BooleanPrefMember& data_reduction_proxy_enabled,
+      const net::ProxyConfig& data_reduction_proxy_config);

[bengr, 2014/08/29 19:29:48]

Update the comment to describe this parameter.

[megjablon, 2014/08/29 20:26:32]

Done.

 
   void RecordBypassEventHistograms(const net::ProxyServer& bypassed_proxy,
                                    int net_error) const;
@@ -71,6 +72,7 @@ class DataReductionProxyUsageStats
     NOT_BYPASSED = 0,         /* Not bypassed. */
     SSL,                      /* Bypass due to SSL. */
     LOCAL_BYPASS_RULES,       /* Bypass due to client-side bypass rules. */
+    MANAGED_PAC,              /* Bypass due to managed config. */

[bengr, 2014/08/29 19:29:48]

This isn't quite right. I'd call this MANAGED_PROXY_CONFIG, because it doesn't
necessary have to be a PAC.

[megjablon, 2014/08/29 20:26:32]

Done.

     AUDIO_VIDEO,              /* Audio/Video bypass. */
     TRIGGERING_REQUEST,       /* Triggering request bypass. */
     NETWORK_ERROR,            /* Network error. */