chrome/browser/net/chrome_network_delegate.cc - Issue 510353004: Fixing DataReductionProxy.BypassedBytes.LocalBypassRules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 510353004: Fixing DataReductionProxy.BypassedBytes.LocalBypassRules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changing managed pac reporting Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/data_reduction_proxy/browser/data_reduction_proxy_params.h » ('j') | components/data_reduction_proxy/browser/data_reduction_proxy_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/chrome_network_delegate.cc

diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc

index d69e0eb1a4c4397d0fd21c01eb3284d807baaaf7..e57a23b1b63da153c999b397380ed0f9d9a5cc4d 100644

--- a/chrome/browser/net/chrome_network_delegate.cc

+++ b/chrome/browser/net/chrome_network_delegate.cc

@@ -583,9 +583,12 @@ void ChromeNetworkDelegate::OnCompleted(net::URLRequest* request,

RecordContentLengthHistograms(received_content_length,

original_content_length,

freshness_lifetime);

- if (data_reduction_proxy_enabled_ && data_reduction_proxy_usage_stats_) {

+ if (data_reduction_proxy_enabled_ && data_reduction_proxy_usage_stats_ &&

bengr 2014/08/29 19:29:47 nit: It might be a bit cleaner to put each conditi

megjablon 2014/08/29 20:26:32 Done.

+ !proxy_config_getter_.is_null()) {

data_reduction_proxy_usage_stats_->RecordBypassedBytesHistograms(

- *request, *data_reduction_proxy_enabled_);

+ *request,

+ *data_reduction_proxy_enabled_,

+ proxy_config_getter_.Run());

}

DVLOG(2) << __FUNCTION__

<< " received content length: " << received_content_length