components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h - Issue 510353004: Fixing DataReductionProxy.BypassedBytes.LocalBypassRules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h

Issue 510353004: Fixing DataReductionProxy.BypassedBytes.LocalBypassRules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing comment and adding check if proxy is enabled Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/browser/data_reduction_proxy_params.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h b/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h

index f147bb3c9a2a984ad38539588e7b5a5fd868c1b2..33fd29e560fa2f533fa044f1c3be60a83537c599 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h

@@ -55,13 +55,14 @@ class DataReductionProxyUsageStats

// cause the current bypass.

void SetBypassType(DataReductionProxyBypassType type);

- // Given the |content_length| and associated |request|, records the

- // number of bypassed bytes for that |request| into UMAs based on bypass type.

- // |data_reduction_proxy_enabled| tells us the state of the

- // kDataReductionProxyEnabled preference.

+ // Given |data_reduction_proxy_enabled|, a |request|, and the

+ // |data_reduction_proxy_config| records the number of bypassed bytes for that

+ // |request| into UMAs based on bypass type. |data_reduction_proxy_enabled|

+ // tells us the state of the kDataReductionProxyEnabled preference.

void RecordBypassedBytesHistograms(

net::URLRequest& request,

- const BooleanPrefMember& data_reduction_proxy_enabled);

+ const BooleanPrefMember& data_reduction_proxy_enabled,

+ const net::ProxyConfig& data_reduction_proxy_config);

void RecordBypassEventHistograms(const net::ProxyServer& bypassed_proxy,

int net_error) const;

@@ -71,6 +72,7 @@ class DataReductionProxyUsageStats

NOT_BYPASSED = 0, /* Not bypassed. */

SSL, /* Bypass due to SSL. */

LOCAL_BYPASS_RULES, /* Bypass due to client-side bypass rules. */

+ MANAGED_PROXY_CONFIG, /* Bypass due to managed config. */

AUDIO_VIDEO, /* Audio/Video bypass. */

TRIGGERING_REQUEST, /* Triggering request bypass. */

NETWORK_ERROR, /* Network error. */